Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pagination calculation error #59

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

bartoszkubicki
Copy link
Contributor

Fix for pagination calculation error. Example - we run out of memory on 28th page of webapi endpoint, but we have 6 pages left. Before the fix these pages were ommited due to comparing start page to pages left calculated from remaining items. From now on we compare to global pages amount, so in that case 34.

@bartoszkubicki bartoszkubicki requested a review from pknap October 28, 2022 11:18
@bartoszkubicki bartoszkubicki merged commit b9a4233 into master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants