Amend getStaticPackages() to use PackageInterface #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-paterson
changed the title
getStaticPackages() to use PackageInterface
|
Yo @adam-paterson Could you add a test with an |
|
@AydinHassan Sure thing |
When an instance of `\Composer\Package\AliasPackage` is found `getStaticPackages()` throws an exception. All packages are required to implement `\Composer\Package\PackageInterface` so it makes more sense for the closure arguement to require that instead.
adam-paterson
force-pushed
the
hotfix/package-interface
branch
from
858225b to
2b1c3fd
Compare
|
@AydinHassan let me know if the test meets your expectations? It'd be nice to remove the repo declaration from my project. <3 |
|
yeah perfect @adam-paterson , thank you :) |
AydinHassan
added a commit
that referenced
this pull request
Oct 8, 2015
Amend getStaticPackages() to use PackageInterface
|
@adam-paterson just tagged 2.2.3 |
|
@AydinHassan Thanks mate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instance of
\Composer\Package\AliasPackageis foundgetStaticPackages()throws an exception.All packages are required to implement
\Composer\Package\PackageInterfaceso it makes more sense for the closure argument to require that instead.