This repository has been archived by the owner on Dec 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trey2k
approved these changes
Feb 26, 2024
Looks good, just going to wait on actions and I will merge. MacOS actions are still failing but I hope to have that fixed soon. Thanks! |
I'm not sure if the gdextension unit tests are failing due to this PR or actions getting messed up. I suspect actions but will confirm when I get home later tonight. |
Going to retry the builds as I can not reproduce this locally. |
I tried this on my m1 Mac and it does compile however I cannot open the demo project. Here is the report.
|
I'm unable to reproduce this. I'm able to load demo projects, legacy projects and create new projects without any issues. |
This PR is working for me on apple silicon and on ios with the latest 4.2 branch of godot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting Godot String to const char* is having strange issues on Mac. So while that is tracked down, this change allows the Lua libraries to load by changing the implantation to no longer require the conversion of Godot String's to char*