Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #27

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Fix typos #27

merged 3 commits into from
Aug 2, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Aug 2, 2023

Fix half the misspellings with typos.

I took the liberty to rename $unit_espace = ' '; to $unit_nbspace leaving espace to Renault :)

.typos.toml

[files]
extend-exclude = [
    "public/css/",
    "public/font/",
    "public/js/"
]
[default.extend-identifiers]
"ND" = "ND"
"WeeWX" = "WeeWX"
"Wordpress" = "WordPress"
[default.extend-words]
# The other half to fix
"datas" = "datas"
"informations" = "informations"
"serie" = "serie"

Please consider renaming: datas, informations, serie - these are not in English.
You may also like https://github.com/szepeviktor/uninformative-words

@jaz-on jaz-on added first time contributor Issue or PR opened by a first-time contributor to the repository [Needs] Testing [Priority] Low [Status] In Progress Tracking issues with work in progress labels Aug 2, 2023
@jaz-on jaz-on self-assigned this Aug 2, 2023
@jaz-on jaz-on self-requested a review August 2, 2023 19:32
@jaz-on jaz-on added this to the 3.8.14 milestone Aug 2, 2023
@jaz-on
Copy link
Member

jaz-on commented Aug 2, 2023

Thanks @szepeviktor for the PR. I didn't know about crate-ci/typos and your little repo, II appreciate it.

I'll dig into it and learn how to apply it to this project, it's going to be very useful when it comes to checking simple mistakes.

May I ask you how you ended up reviewing the Weather Station plugin repo? :)

@jaz-on jaz-on merged commit f9cfbfc into Weather-Station-Software:master Aug 2, 2023
@szepeviktor
Copy link
Contributor Author

how you ended up reviewing the Weather Station plugin repo? :)

This way

image

@szepeviktor szepeviktor deleted the non-serie-typos branch August 2, 2023 21:09
@szepeviktor
Copy link
Contributor Author

Please consider renaming: datas, informations, serie - these are not in English.

The next step could be.

https://github.com/search?q=repo%3AWeather-Station-Software%2Flive-weather-station%20%22informations%22&type=code

In English, "information" is an uncountable mass noun.

@jaz-on
Copy link
Member

jaz-on commented Aug 2, 2023

Pierre, the original developer, and I are French.

As these words are also used in French (and countable in our mother language), we made mistakes when naming parts of the codebase...

I'll work on it and be way more strict on the naming convention in the future thanks for the heads-up!😉

@szepeviktor
Copy link
Contributor Author

ChatGPT agrees!

image

@jaz-on jaz-on added [Type] Enhancement New feature or request and removed [Needs] Testing [Priority] Low [Status] In Progress Tracking issues with work in progress labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first time contributor Issue or PR opened by a first-time contributor to the repository [Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants