Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining typos #30

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Fix remaining typos #30

merged 3 commits into from
Aug 7, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Aug 3, 2023

An inspiration, not a PR

informations -> information
serie -> series
datas -> measurements

In 3 separate commits.

Fixes #29

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Aug 3, 2023

"datas" could be also results or details ... Ask ChatGPT!

image

@jaz-on
Copy link
Member

jaz-on commented Aug 7, 2023

Again, thank you so much for your help @szepeviktor.
Your contributions are valued, any help is welcome! 🫶

I like your idea of replacing the generic "data" word with "measurements", I think that's a nice alternative. Let's see if it fits every case, but for now, I'll accept this proposal.

@jaz-on jaz-on merged commit 629749e into Weather-Station-Software:master Aug 7, 2023
@jaz-on jaz-on added this to the 3.8.14 milestone Aug 7, 2023
@jaz-on jaz-on self-assigned this Aug 7, 2023
@jaz-on jaz-on self-requested a review August 7, 2023 11:01
@jaz-on jaz-on added [Type] Enhancement New feature or request [Priority] Low labels Aug 7, 2023
@szepeviktor szepeviktor deleted the 3typos branch August 7, 2023 11:04
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming uncountable words + enhancing Github actions
2 participants