Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE-1044 Feature/url fixes #132

Merged
merged 11 commits into from
Jul 30, 2024
Merged

FE-1044 Feature/url fixes #132

merged 11 commits into from
Jul 30, 2024

Conversation

PavlosTze
Copy link
Member

@PavlosTze PavlosTze commented Jul 29, 2024 •
edited
Loading

  • Make links consistent and aligned between "same category" ones.
  • Fixed some indentation issues and, single vs double quotes and removed some unnecessary params in documents such as id, slug, hide_title=false etc

Testing

Ensure that navigating throughout the app works correctly and the links changed are OK as commented in the respective Linear issue.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80c7ae6
Status: ✅  Deploy successful!
Preview URL: https://b82040c3.docs-33x.pages.dev
Branch Preview URL: https://feature-url-fixes.docs-33x.pages.dev

View logs

@PavlosTze PavlosTze marked this pull request as ready for review July 30, 2024 11:43
JohnFrontzos
JohnFrontzos approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@JohnFrontzos JohnFrontzos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clicked on every link the docs website has and could not find any dead.

@PavlosTze PavlosTze merged commit 47970b2 into main Jul 30, 2024
3 checks passed
@PavlosTze PavlosTze deleted the feature/url-fixes branch July 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnFrontzos JohnFrontzos JohnFrontzos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PavlosTze @JohnFrontzos