Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #211

Merged
merged 24 commits into from
Oct 14, 2024
Merged

Dev #211

merged 24 commits into from
Oct 14, 2024

Conversation

hta218
Copy link
Member

@hta218 hta218 commented Oct 14, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new Modal component for enhanced dialog functionality.
    • Added ProductTag and VariantPrices components for improved product display.
    • Implemented a QuickView component for quick product previews.
    • Enhanced CollectionFilters and CollectionList components for better layout and usability.
  • Improvements

    • Increased maximum animation time for the Marquee component.
    • Added a pulsing animation effect to the Skeleton component.
    • Improved the ProductMedia component to conditionally render thumbnails.
  • Bug Fixes

    • Removed deprecated Modal function to streamline modal usage.
  • Chores

    • Updated dependencies in package.json for better component support.
    • Added a new CSS variable for the shop pay button's border radius.

hta218 added 24 commits October 14, 2024 15:52
…ional compare-at prices and discount handling
…ayout consistency across the collection list and cards
Copy link
Contributor

coderabbitai bot commented Oct 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across multiple components in the application. Key changes include an increase in the maxAnimationTime for the Marquee component, the addition of a new Modal component utilizing Radix UI, and the introduction of a ProductTag component. Other updates involve the restructuring of existing components like CollectionFilters, Blogs, and BlogPost to enhance their layout and integrate new props. Additionally, the ProductCard component has been removed, and its functionality has been replaced with a new implementation. Various components have undergone styling and structural adjustments.

Changes

File Change Summary
app/components/marquee.tsx Updated maxAnimationTime from 100000 to 400000 milliseconds.
app/components/modal.tsx Introduced a new Modal, ModalTrigger, ModalContent, and ModalClose components using Radix UI.
app/components/product-tag.tsx Added new ProductTag component accepting children and className.
app/components/skeleton.tsx Added animate-pulse class to Skeleton component.
app/components/variant-prices.tsx Introduced VariantPrices component for displaying product variant prices.
app/modules/add-to-cart-button.tsx Simplified inputs prop in AddToCartButton and adjusted AddToCartAnalytics parsing.
app/modules/cart-best-sellers.tsx Removed quickAdd prop from ProductCard in CartBestSellers.
app/modules/drawer-filter.tsx Enhanced DrawerFilter and SortMenu components with new imports and styling adjustments.
app/modules/header/announcement-bar.tsx Modified Marquee rendering logic and updateStyles function.
app/modules/header/desktop-header.tsx Adjusted z-index values for header elements.
app/modules/header/mobile-header.tsx Simplified className logic for the <header> element.
app/modules/modal.tsx Deprecated Modal function, recommending use of ~/components/modal.
app/modules/product-card.tsx Removed ProductCard component.
app/modules/product-card/index.tsx Introduced new ProductCard component with structured product display.
app/modules/product-card/quick-view.tsx Added QuickView and QuickViewTrigger components for product quick view functionality.
app/modules/product-form/product-media.tsx Added showThumbnails prop to ProductMedia for conditional thumbnail rendering.
app/routes/($locale).blogs.$blogHandle.$articleHandle.tsx Changed variable declarations from const to let.
app/routes/($locale).blogs.$blogHandle._index.tsx Improved type safety by removing non-null assertions.
app/routes/($locale).collections.$collectionHandle.tsx Changed variable declarations from const to let.
app/routes/($locale).collections._index.tsx Updated exports from const to let for flexibility.
app/sections/blog-post.tsx Replaced section with Section component and updated layout.
app/sections/blogs.tsx Streamlined imports and replaced PageHeader with <h3> element.
app/sections/collection-filters/index.tsx Updated to use <Section> and simplified markup.
app/sections/collection-filters/products-loaded-on-scroll.tsx Removed quickAdd prop from ProductCard.
app/sections/collection-list/collection-card.tsx Adjusted layout and replaced Heading with <h6>.
app/sections/collection-list/index.tsx Removed PageHeader and updated to use <Section>.
app/sections/product-information/index.tsx Modified state handling and rendering logic for ProductInformation.
app/styles/app.css Added new CSS custom property --shop-pay-button-border-radius.
package.json Added dependencies: @phosphor-icons/react and @radix-ui/react-dialog.

Possibly related PRs

  • Fix bug swiper for product media #209: The changes in the ProductMedia component involve the use of a useEffect hook, which is relevant to the Marquee component's use of useEffect for setting the contentWidth.

Suggested reviewers

  • paul-phan

🐇 In the meadow where changes bloom,
A Modal now opens, dispelling the gloom.
With ProductTag and VariantPrices in sight,
Our app's looking sharper, oh what a delight!
The Marquee rolls on, with time to spare,
Hop along, dear friends, let's update with flair! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hta218 hta218 merged commit 3b64b20 into main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant