Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vue demo app solana type #2007

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix vue demo app solana type #2007

merged 1 commit into from
Nov 7, 2024

Conversation

hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Nov 7, 2024 •
edited
Loading

Motivation and Context

Jira Link:
NA

Description

Fix type in Vue Demo App in solanaHandler

How has this been tested?

run Demo App build and dev.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w hieu-w requested a review from chaitanyapotti November 7, 2024 10:26
chaitanyapotti
chaitanyapotti approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@chaitanyapotti chaitanyapotti merged commit 8793f76 into master Nov 7, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/Fix-Demo-app-CI-build-fail branch November 7, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieu-w @chaitanyapotti