Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nft checkout plugin #2018

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Feat/nft checkout plugin #2018

merged 12 commits into from
Dec 4, 2024

Conversation

tanguyenvn
Copy link
Contributor

@tanguyenvn tanguyenvn commented Nov 21, 2024

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/PD-3995

Description

  • The plugin package can be used in conjunction with the Web3Auth SDK.
  • The embed package can be used as a standalone solution.

How has this been tested?

Screenshots (if appropriate):

  • demo app: config
image - demo app: logged in image - demo app: show NFT free mint image image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@BboyStatix BboyStatix self-requested a review November 21, 2024 11:01
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. this looks good for a first version. we can iterate based on client feedback.
Future versions might want apikey to be same as clientId

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 6:14am

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 02ba0ce into master Dec 4, 2024
5 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/nft-checkout-plugin branch December 4, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants