Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make __wasi_linkcount_t 64-bit #70

Closed
sunfishcode opened this issue Jul 26, 2019 · 1 comment · Fixed by #127
Closed

Make __wasi_linkcount_t 64-bit #70

sunfishcode opened this issue Jul 26, 2019 · 1 comment · Fixed by #127
Labels
wasi-filesystem Issues targeted for a `wasi_unstable_filesystem` module

Comments

@sunfishcode
Copy link
Member

__wasi_countcount_t is currently a uint32_t. We should change it to uint64_t in order to support hypothetical filesystems with very large link counts. For comparison, the nlink function in Rust returns a 64-bit value.

This will increase the size of __wasi_filestat_t, however that seems negligible.

For comparison, the userspace nlink_t is already a uint64_t: https://github.com/rust-lang/libc/blob/master/src/wasi.rs#L34.
@sunfishcode sunfishcode added the wasi-filesystem Issues targeted for a `wasi_unstable_filesystem` module label Jul 26, 2019
@sunfishcode sunfishcode mentioned this issue Jul 26, 2019
Merged
@jedisct1
Copy link
Member

Good point. Yes, it would totally make sense to increase it to 64 bit.

@peterhuene peterhuene mentioned this issue Oct 24, 2019
Merged
sunfishcode pushed a commit that referenced this issue Oct 31, 2019
@peterhuene @sunfishcode
Change hard link count to 64-bits. (#127)
5a8d999 
This commit changes the type for `__wasi_linkcount_t` to 64-bits to support
large link counts.

Fixes #70.
ibmibmibm added a commit to WasmEdge/WasmEdge that referenced this issue Dec 7, 2020
@ibmibmibm
[WASI] Update size of linkcount to u64
5d54bbc 
See WebAssembly/WASI#70
q82419 pushed a commit to WasmEdge/WasmEdge that referenced this issue Dec 7, 2020
@ibmibmibm @q82419
[WASI] Update size of linkcount to u64
87b589c 
See WebAssembly/WASI#70
hydai pushed a commit to WasmEdge/WasmEdge that referenced this issue Dec 7, 2020
@ibmibmibm @hydai
[WASI] Update size of linkcount to u64
840e6bf 
See WebAssembly/WASI#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wasi-filesystem Issues targeted for a `wasi_unstable_filesystem` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change hard link count to 64-bits.
2 participants
@jedisct1 @sunfishcode