Use absolute memory addresses for emasm string indexes. #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| auto* value = arg->cast<Const>(); | ||
| auto code = codeForConstAddr(wasm, segmentOffsets, value); | ||
| auto& asmConst = createAsmConst(code, sig, importName); | ||
| int32_t address = value->value.geti32(); |
There was a problem hiding this comment.
Is there any reason codeForConstAddr changed from taking a Const* to an int32_t? It seems like this was a partial change that didn't make it in to the final PR, so the effect was that we just outlined the value->value.geti32() bit.
There was a problem hiding this comment.
Right, I outlines it because it need to use that address in two places now. Maybe I should just have both consumers call ->value.geti32()?
Before we used 0-based indexes which meant that we needed to modify the code calling the emask function to replace the first argument. Now we use the string address itself as the index/code for the emasm constant. This allows use code to go unmodifed as the emscripten side will accept the memory address as the index/code. See: emscripten-core/emscripten#9013
sbc100
force-pushed
the
fix_pic_em_asm
branch
from
75aefd1 to
865545d
Compare
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we used 0-based indexes which meant that we needed to modify the
code calling the emask function to replace the first argument.
Now we use the string address itself as the index/code for the emasm
constant. This allows use code to go unmodifed as the emscripten side
will accept the memory address as the index/code.
See: emscripten-core/emscripten#9013