Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print '(offset ...)` in data and element segments #6379

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Print '(offset ...)` in data and element segments #6379

merged 2 commits into from
Mar 6, 2024

Commits on Mar 6, 2024

  1. Print '(offset ...)` in data and element segments 

    Previously we just printed the offset instruction(s) directly, which is a valid
shorthand only when there is a single instruction. In the case of extended
constant instructions, there can potentially be multiple instructions, in which
case the explicit `offset` clause is required. For simplicity, always print the
full `offset` clause.
    @tlively
    tlively committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d1d82b5 View commit details
    Browse the repository at this point in the history

  2. use shorthand when possible

    @tlively
    tlively committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    687b31d View commit details
    Browse the repository at this point in the history