-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Literal::externalize/internalize for strings and shareability #6784
Conversation
It is worth testing shared i31s (which will reveal that the assertion at the beginning of |
Ok, I added testing for shared i31. That found a few more places that needed shareability fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to note is that now that we are closer to being able to run and directly import the upstream spec tests, any additional testing we add to our own spec tests will be able to eventually benefit everyone.
Co-authored-by: Thomas Lively <tlively123@gmail.com>
ASan tests found another issue with shareability, in a destructor. Fixed. @tlively I am getting a little worried that we may have many more places with |
Good idea, I will take a look. |
Is it worth testing shareability here? (is the fuzzer ready?)