Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Literal::externalize/internalize for strings and shareability #6784

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Jul 24, 2024

Is it worth testing shareability here? (is the fuzzer ready?)

@kripken kripken requested a review from tlively July 24, 2024 17:39
@tlively
Copy link
Member

tlively commented Jul 24, 2024

It is worth testing shared i31s (which will reveal that the assertion at the beginning of Literal::externalize() needs to be updated), but the fuzzer does not support shared stringref yet.

@kripken
Copy link
Member Author

kripken commented Jul 25, 2024

Ok, I added testing for shared i31. That found a few more places that needed shareability fixes.

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note is that now that we are closer to being able to run and directly import the upstream spec tests, any additional testing we add to our own spec tests will be able to eventually benefit everyone.

src/wasm/literal.cpp Outdated Show resolved Hide resolved
kripken and others added 2 commits July 29, 2024 08:56
Co-authored-by: Thomas Lively <tlively123@gmail.com>
@kripken
Copy link
Member Author

kripken commented Jul 29, 2024

ASan tests found another issue with shareability, in a destructor. Fixed.

@tlively I am getting a little worried that we may have many more places with x.getHeapType() == HeapType::y that ignore shareability. Perhaps we should audit them all somehow?

@tlively
Copy link
Member

tlively commented Jul 29, 2024

Good idea, I will take a look.

@kripken kripken merged commit eac0846 into WebAssembly:main Jul 29, 2024
13 checks passed
@kripken kripken deleted the extern.string branch July 29, 2024 18:37
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants