Stack switching: fix some optimization passes #7271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Feb 3, 2025
test/lit/passes/stack_switching.wast
Outdated
| @@ -0,0 +1,163 @@ | |||
| ;; NOTE: Assertions have been generated by update_lit_checks.py and should not be edited. | |||
| ;;RUN: wasm-opt -all -O3 -Oz %s -S -o - | filecheck %s | |||
There was a problem hiding this comment.
Would you be able to break this up into targeted tests for the individual fixed optimization passes? Also, the new test files should be added to the list of ignored tests in scripts/fuzzing.py until scripts/fuzz_opt.py can run cleanly without that.
vouillon
force-pushed
the
stack-switching-fixes
branch
from
c067464 to
19e57a7
Compare
Update the type of the blocks that are targets of the handlers of resume and resume_throw instructions.
We were incorrectly comparing a tag name with block types.
vouillon
force-pushed
the
stack-switching-fixes
branch
from
19e57a7 to
50d6418
Compare
vouillon
commented
Feb 7, 2025
Comment on lines
+1446
to
+1449
| assert(params.size() > 0); | ||
| Type cont = params[params.size() - 1]; | ||
| assert(cont.isContinuation()); | ||
| type = cont.getHeapType().getContinuation().type.getSignature().params; |
There was a problem hiding this comment.
@dhil Does this look correct to you?
There was a problem hiding this comment.
Yes, it looks right to me. The last parameter of a switch-continuation must be a continuation type. This argument is synthetic in the sense that it is provided by switch rather than the programmer.
MaxGraey
reviewed
Feb 11, 2025
Co-authored-by: Max Graey <maxgraey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #7041 by adapting the optimizations passes to work with the stack switching instructions.