Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what "specialized" means. #320

Merged

Conversation

sunfishcode
Copy link
Member

Add a paragraph documenting specialized types and their relationship to despecialized types.

This is intended to help with #319.

Add a paragraph documenting specialized types and their relationship to
despecialized types.

This is intended to help with WebAssembly#319.
design/mvp/Explainer.md Outdated Show resolved Hide resolved
design/mvp/Explainer.md Outdated Show resolved Hide resolved
Copy link
Member

@lukewagner lukewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea! I made a few suggested tweaks:

design/mvp/Explainer.md Outdated Show resolved Hide resolved
sunfishcode and others added 3 commits March 18, 2024 08:24
Co-authored-by: Luke Wagner <mail@lukewagner.name>
This makes the sentence structure more consistent.
@sunfishcode
Copy link
Member Author

Thanks! I made a few additinoal minor wording adjustments; in particular, I clarified that the property that values can have different representations isn't specific to the Canonical ABI, which will matter more when the component model grows new features involving encoded values.

Copy link
Member

@lukewagner lukewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll wait a few days for any final comments then merge.

@lukewagner lukewagner merged commit 1de837a into WebAssembly:main Mar 21, 2024
1 check passed
@sunfishcode sunfishcode deleted the sunfishcode/doc-despecialized branch March 21, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants