Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec binary format #383

Merged
merged 7 commits into from
Jun 13, 2023
Merged

Spec binary format #383

merged 7 commits into from
Jun 13, 2023

Conversation

rossberg
Copy link
Member

@rossberg rossberg commented May 31, 2023

Note: this does not yet take #372 into consideration, i.e., uses the temporary opcodes for now.

@rossberg rossberg requested a review from tlively May 31, 2023 17:14
@rossberg rossberg mentioned this pull request May 31, 2023
53 tasks
@jakobkummerow
Copy link
Contributor

Is it intentional or an oversight that this PR disregards #372 and the discussion that happened there?

Also, instructions.rst line 103:

:ref:`Reference instructions <syntax-instr-ref>` are represented by single byte codes.

is now outdated (since it's an unmodified line, the review tool won't let me put a comment there).

@rossberg
Copy link
Member Author

rossberg commented Jun 1, 2023

Is it intentional or an oversight that this PR disregards #372 and the discussion that happened there?

Since that isn't resolved yet, but I wanted to make progress with the spec, I did it based on the old opcodes for now. It's easily changed once #372 is finalised.

:ref:`Reference instructions <syntax-instr-ref>` are represented by single byte codes.

is now outdated (since it's an unmodified line, the review tool won't let me put a comment there).

Thanks, updated.

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

largely rubber stamp lgtm

@rossberg rossberg merged commit 90d0d41 into main Jun 13, 2023
@rossberg rossberg deleted the spec.binary branch June 13, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants