Bulk array validation #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
rossberg
approved these changes
Jul 19, 2023
document/core/valid/matching.rst
Outdated
| .. index:: storage type | ||
| .. _match-storagetype: | ||
|
|
||
| Storage Types |
document/core/valid/instructions.rst
Outdated
| .. _valid-array.fill: | ||
|
|
||
| :math:`\ARRAYFILL~x` | ||
| ........................... |
document/core/valid/instructions.rst
Outdated
|
|
||
| .. math:: | ||
| \frac{ | ||
| \expand(C.\CTYPES[x]) = \TARRAY~(\MVAR~\X{st_1}) \qquad \expand(C.\CTYPES[y]) = \TARRAY~(\mut~\X{st_2}) \qquad C \vdashstoragetypematch \X{st_2} \matchesstoragetype \X{st_1} |
There was a problem hiding this comment.
Suggested change
| \expand(C.\CTYPES[x]) = \TARRAY~(\MVAR~\X{st_1}) \qquad \expand(C.\CTYPES[y]) = \TARRAY~(\mut~\X{st_2}) \qquad C \vdashstoragetypematch \X{st_2} \matchesstoragetype \X{st_1} | |
| \expand(C.\CTYPES[x]) = \TARRAY~(\MVAR~\X{st_1}) | |
| \qquad | |
| \expand(C.\CTYPES[y]) = \TARRAY~(\mut~\X{st_2}) | |
| \qquad | |
| C \vdashstoragetypematch \X{st_2} \matchesstoragetype \X{st_1} |
rossberg
reviewed
Jul 19, 2023
document/core/valid/matching.rst
Outdated
| @@ -147,9 +147,6 @@ A :ref:`value type <syntax-valtype>` :math:`\valtype_1` matches a :ref:`value ty | |||
| } | |||
|
|
|||
|
|
|||
| .. index:: result type, value type | |||
| .. _match-resulttype: | |||
|
|
|||
document/core/valid/instructions.rst
Outdated
|
|
||
| .. _valid-array.init_elem: | ||
|
|
||
| :math:`\ARRAYINITELEM~x~y |
There was a problem hiding this comment.
This seems to be missing a closing tick.
|
We'll wait on #382 to land this, since it no longer builds independently. |
Add validation rules (prose and formalism) for `array.fill`, `array.copy`, `array.init_data`, and `array.init_elem`. As part of the rules for `array.copy`, extend the `matches` relation to storage types.
tlively
force-pushed
the
bulk-array-validation
branch
from
e639ed8 to
c5861b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation rules (prose and formalism) for
array.fill,array.copy,array.init_data, andarray.init_elem. As part of the rules forarray.copy,extend the
matchesrelation to storage types.