Rename to laneselect #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in WebAssembly#17 (comment).
Maratyszcza
reviewed
Oct 1, 2021
| @@ -182,17 +182,17 @@ where: | |||
| - the intermediate `b * c` is be rounded first, and the final result rounded again (for a total of 2 roundings), or | |||
| - the the entire expression evaluated with higher precision and then only rounded once (if supported by hardware). | |||
|
|
|||
| ### Relaxed bitselect (blend/laneselect) | |||
| ### Relaxed laneselect | |||
There was a problem hiding this comment.
I suggest just "laneselect", without "relaxed"
There was a problem hiding this comment.
The relaxed isn't really part of the name, plus the names aren't confirmed. I can file an issue for this. I think the instruction names should reflect this non-determinism, it doesn't have to be "relaxed".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in
#17 (comment).