[spec/interpreter/test] Land bulk instructions & reference types proposals #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue #3.
This aligns with current interest in using `mem.` prefix for memory operations, see #627 and WebAssembly/threads#62 (comment).
Also remove some of the stuff from the bulk memory proposal that really should be written in the spec ReST files.
I think it's a better name than `set`, especially considering we may have a `table.set` in the future, which will likely set just one value. It also follows naming of [Array.prototype.fill](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/fill) which has similar behavior.
Also fix some typos I noticed.
This follows the naming discussed in issue #627.
* [spec] Initial documentation of syntax Includes the basic structure needed for the proposal, but no validation, binary, text or execution.
Using `memory.init` or `memory.drop` on an active segment is a validation error, not a trap.
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 14, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 14, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 14, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 14, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 14, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 15, 2021
This was referenced Apr 15, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 19, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 20, 2021
gumb0
added a commit
to wasmx/wasm-spec
that referenced
this pull request
Apr 20, 2021
jblebrun
reviewed
May 8, 2021
| @@ -251,7 +315,7 @@ | |||
| (assert_return (invoke "as-br_table-last" (i32.const 1)) (i32.const 2)) | |||
|
|
|||
| (assert_return (invoke "as-call_indirect-first" (i32.const 0)) (i32.const 3)) | |||
| (assert_return (invoke "as-call_indirect-first" (i32.const 1)) (i32.const 2)) | |||
| ;;(assert_return (invoke "as-call_indirect-first" (i32.const 1)) (i32.const 2)) | |||
There was a problem hiding this comment.
Was it intentional that this was commented out?
There was a problem hiding this comment.
Hm, probably not, but I can't trace back where it came from. Mind creating a PR to reactivate it?
There was a problem hiding this comment.
No problem, I've done so here: #1323
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 15, 2021
The proposal was merged in <WebAssembly/spec#1287>.
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 15, 2021
The proposal was merged in <WebAssembly/spec#1287>.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 3, 2021
…e main tests., a=testonly Automatic update from web-platform-tests Merge wasm reference types tests into the main tests. The proposal was merged in <WebAssembly/spec#1287>. -- wpt-commits: d6752ceced9f95d19e317693d2ba902e9fc9cd35 wpt-pr: 30805
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 4, 2021
…e main tests., a=testonly Automatic update from web-platform-tests Merge wasm reference types tests into the main tests. The proposal was merged in <WebAssembly/spec#1287>. -- wpt-commits: d6752ceced9f95d19e317693d2ba902e9fc9cd35 wpt-pr: 30805
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 4, 2021
…e main tests., a=testonly Automatic update from web-platform-tests Merge wasm reference types tests into the main tests. The proposal was merged in <WebAssembly/spec#1287>. -- wpt-commits: d6752ceced9f95d19e317693d2ba902e9fc9cd35 wpt-pr: 30805
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 6, 2021
…e main tests., a=testonly Automatic update from web-platform-tests Merge wasm reference types tests into the main tests. The proposal was merged in <WebAssembly/spec#1287>. -- wpt-commits: d6752ceced9f95d19e317693d2ba902e9fc9cd35 wpt-pr: 30805
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
The proposal was merged in <WebAssembly/spec#1287>.
tomstuart
added a commit
to tomstuart/WebAssembly-spec
that referenced
this pull request
Feb 18, 2023
This rule was probably copied from the (very similar) memory.grow rule when it was introduced by WebAssembly#1287 in c3d5cbc. While memory.grow doesn’t have an initialization value, table.grow does.
backes
added a commit
to backes/spec
that referenced
this pull request
May 10, 2023
Those tests were moved to `binary-leb128.wast` in WebAssembly#1019, but WebAssembly#1287 brought them back.
backes
added a commit
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per WG vote on 2021-02-10, both proposals have been promoted to phase 5 and are ready to be merged.
This PR includes both of them together, since they are mutually dependent. Technically, this is a merge of the reference-types repo, which already contained all parts of the bulk instructions repo, plus conflict resolutions and additions to fill in gaps.