Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiple-return-type support #53

Merged
merged 4 commits into from
Sep 14, 2015
Merged

Conversation

lukewagner
Copy link
Member

As discussed in #15, this patch changes expression types from type lists to single types. Since some expressions don't return anything (e.g., break), expr_type = value_type option, as suggested in #15.

@lukewagner lukewagner force-pushed the single-return-type branch 3 times, most recently from 40086ab to 1645c20 Compare September 10, 2015 04:13
@lukewagner
Copy link
Member Author

@rossberg-chromium Thanks! Fixed everything except where prevented by the two issues noteda bove.

@lukewagner
Copy link
Member Author

Great, agreed and addressed all comments.

lukewagner added a commit that referenced this pull request Sep 14, 2015
Remove multiple-return-type support
@lukewagner lukewagner merged commit 5ac7a32 into master Sep 14, 2015
@lukewagner lukewagner deleted the single-return-type branch September 14, 2015 17:26
@lukewagner
Copy link
Member Author

Merging based on LGTM

littledan pushed a commit to littledan/spec that referenced this pull request Mar 4, 2018
In section "Initializing Memory Only Once" the WebAssembly.instantiate is missing a paren.
eqrion pushed a commit to eqrion/wasm-spec that referenced this pull request Sep 18, 2019
…bAssembly#53)

* Adjust element segment encoding to match the bulk-memory proposal

* Update interpreter/binary/encode.ml

Co-Authored-By: Andreas Rossberg <rossberg@mpi-sws.org>

* Address comments
alexcrichton pushed a commit to alexcrichton/spec that referenced this pull request Nov 18, 2019
rossberg added a commit that referenced this pull request Jul 3, 2024
Add missing memory specifier to memory.init execution semantics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants