Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define thread local storage conventions #116

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Define thread local storage conventions #116

merged 4 commits into from
Jul 19, 2019

Conversation

quantum5
Copy link
Member

No description provided.

@quantum5 quantum5 requested review from sbc100 and tlively July 16, 2019 00:35
Linking.md Outdated Show resolved Hide resolved
@sunfishcode sunfishcode self-requested a review July 16, 2019 17:39
Linking.md Outdated Show resolved Hide resolved
Linking.md Outdated Show resolved Hide resolved
Linking.md Outdated Show resolved Hide resolved
Linking.md Outdated Show resolved Hide resolved
Linking.md Outdated Show resolved Hide resolved
@quantum5 quantum5 merged commit a445ee0 into master Jul 19, 2019
@quantum5 quantum5 deleted the tls-conventions branch July 22, 2019 20:51
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jul 25, 2019
This commit moves `thread_local!` on WebAssembly targets to using the
`#[thread_local]` attribute in LLVM. This was recently implemented
upstream and is [in the process of being documented][dox]. This change
only takes affect if modules are compiled with `+atomics` which is
currently unstable and a pretty esoteric method of compiling wasm
artifacts.

This "new power" of the wasm toolchain means that the old
`wasm-bindgen-threads` feature of the standard library can be removed
since it should now be possible to create a fully functioning threaded
wasm module without intrusively dealing with libstd symbols or
intrinsics. Yay!

[dox]: WebAssembly/tool-conventions#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants