Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm2wat] Assertion failure in BinaryReaderIR::OnReturnCallIndirectExpr #1414

Closed
pventuzelo opened this issue May 10, 2020 · 1 comment
Closed

[wasm2wat] Assertion failure in BinaryReaderIR::OnReturnCallIndirectExpr #1414

pventuzelo opened this issue May 10, 2020 · 1 comment

Comments

@pventuzelo
Copy link

pventuzelo commented May 10, 2020 •
edited
Loading

Hey,

Similar assertion failure than #1413 but in another expression.

Assertion `sig_index < module_->types.size()' failed.

Related code (line 737):

wabt/src/binary-reader-ir.cc

Lines 736 to 738 in e88bc66

Result BinaryReaderIR::OnReturnCallIndirectExpr(Index sig_index, Index table_index) {
assert(sig_index < module_->types.size());
auto expr = MakeUnique<ReturnCallIndirectExpr>();

Reproducing

Download: assert_OnReturnCallIndirectExpr_wabt.zip

Run:

./bin/wasm2wat --enable-all assert_OnReturnCallIndirectExpr_wabt.wasm -o /dev/null
wasm2wat: /home/scop/Documents/wabt/src/binary-reader-ir.cc:737: virtual wabt::Result wabt::(anonymous namespace)::BinaryReaderIR::OnReturnCallIndirectExpr(wabt::Index, wabt::Index): Assertion `sig_index < module_->types.size()' failed.
[1]    13148 abort (core dumped)  ./bin/wasm2wat --enable-all assert_OnReturnCallIndirectExpr_wabt.wasm -o
binji added a commit that referenced this issue May 11, 2020
@binji
Remove range assertions in BinaryReader
ce1e496 
These assertions check to see whether the `sig_index` (i.e. the function
type) are in bounds. But this is the responsibility of the validator,
not the binary reader.

Fixes issues #1413 and #1414.
@binji binji mentioned this issue May 11, 2020
Merged
binji added a commit that referenced this issue May 12, 2020
@binji
Remove range assertions in BinaryReader (#1416)
28af342 
These assertions check to see whether the `sig_index` (i.e. the function
type) are in bounds. But this is the responsibility of the validator,
not the binary reader.

Fixes issues #1413 and #1414.
@pventuzelo
Copy link
Author

fix confirmed

$ wasm2wat --enable-all assert_OnReturnCallIndirectExpr_wabt.wasm 
0000072: error: unexpected opcode: 0xc5

keithw added a commit to Mem2019/wabt that referenced this issue Sep 17, 2022
@keithw
Add regression tests for WebAssembly#1929
96868b8 
The returncallindirect regression is identical to WebAssembly#1414,
but in the interpreter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pventuzelo