Boring and rustcrypto rsa #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzak
force-pushed
the
boring_and_rustcrypto_rsa
branch
from
c5cfd83 to
a01f47b
Compare
jedisct1
reviewed
Jul 26, 2022
| @@ -0,0 +1,439 @@ | |||
| use rsa::pkcs8::{DecodePrivateKey as _, DecodePublicKey as _, EncodePrivateKey as _, EncodePublicKey as _}; | |||
| use rsa::pkcs1::{DecodeRsaPrivateKey as _, DecodeRsaPublicKey as _, LineEnding}; | |||
| //use rsa::pem::LineEncoding; | |||
There was a problem hiding this comment.
Looks like some leftover code :)
There was a problem hiding this comment.
Yup... sorry about that! Fixed.
rjzak
force-pushed
the
boring_and_rustcrypto_rsa
branch
from
a01f47b to
80b3a00
Compare
Signed-off-by: Richard Zak <richard@profian.com>
rjzak
force-pushed
the
boring_and_rustcrypto_rsa
branch
from
80b3a00 to
284ad27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
cargo buildselects Boring SSL for the RSA operations as the defaultcargo build --features rcrypto --no-default-featuresselects RustCrypto's RSA implementationTested and found to work with my branch of Enarx.