descriptor-flags: eliminate non-blocking flag, and therefore set-flags #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A blocking or non-blocking read/write is a determined by which method is used on a read/write stream created from a file. Each of these stream methods must be implemened for all files. Therefore, it does not make sense to specify non-blocking at the file level. The set-flags method was only to be used to set or clear the non-blocking flag, so this entire method may now be eliminated.
pchickey
force-pushed
the
pch/blocking_is_a_stream_concern
branch
from
3359575 to
8ef1f19
Compare
sunfishcode
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A blocking or non-blocking read/write is a determined by which method is used on a read/write stream created from a file. Each of these stream methods must be implemened for all files. Therefore, it does not make sense to specify non-blocking at the file level.
The set-flags method was only to be used to set or clear the non-blocking flag, so this entire method may now be eliminated.