Update request authority documentation #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix up the branch if the rewording looks good to folks. |
lukewagner
approved these changes
Jul 25, 2024
Mossaka
approved these changes
Jul 25, 2024
|
The HTTP/2 spec makes it even more clear: https://www.rfc-editor.org/rfc/rfc7540.html#section-8.1.2.3
|
|
Updated 0.3 draft and regenerated markdown. |
The existing wording refers to a "request's authority", which is not well-defined. This rewords it to refer to the "request's target URI authority" - the "authority" part of the "target URI" of the request, which is well-defined.
ricochet
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing wording refers to a "request's authority", which is not clearly defined by HTTP specs.
This rewords it to refer to the "request's target URI authority" - the "authority" part of the "target URI" of the request, which is well-defined: https://httpwg.org/http-core/draft-ietf-httpbis-semantics-latest.html#target.resource
Also normalize some word casing to match the HTTP Semantics doc.