Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant llvm cmake args #75

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Remove redundant llvm cmake args #75

merged 1 commit into from
Oct 31, 2019

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Oct 30, 2019

No description provided.

@sbc100 sbc100 requested a review from sunfishcode October 30, 2019 19:28
sunfishcode
sunfishcode approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works this way, cool!

@sbc100
Copy link
Member Author

sbc100 commented Oct 30, 2019

yeah, those a legacy settings from the pre-monorepo world I believe.

@sbc100 sbc100 merged commit 1f5bf46 into master Oct 31, 2019
@sbc100 sbc100 deleted the remove_redundant_cmake_args branch October 31, 2019 17:10
kildom pushed a commit to kildom/clang-wasi-port that referenced this pull request Jul 14, 2021
@sbc100 @sunfishcode
Fix predefined macros check after recent clang change
8df0d4c 
This is an alternative to WebAssembly#75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @sunfishcode