generated from WebAssembly/wasi-proposal-template
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync changes from wasmtime repo #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow `accept()` to return transient errors. The original provision was added to align with preview3 streams that may only fail once. However, after discussing with Dan Gohman, we came to the conclusion that a `stream` of `result<>` could do the trick fine too. Fixes: WebAssembly#22 - Fold `ephemeral-ports-exhausted` into `address-in-use`. There is no cross-platform way to know the distinction between them. - Remove `concurrency-conflict` clutter, and just document it to be always possible. - Simplify "not supported", "invalid argument" and "invalid state" error cases. There is a myriad of reasons why an argument might be invalid or an operation might be not supported. But there is few cross platform consistency in which of those error cases result in which error codes. Many wasi-sockets codes were unnecessarily detailed and had no standardized equivalent in POSIX, so wasi-libc will probably just map them all back into a single EOPNOTSUPP or EINVAL or ... - Remove create-tcp/udp-socket not supported errors. These stem from back when the entire wasi-sockets proposal was one big single thing. In this day and age, when an implementation doesn't want to support TCP and/or UDP, it can simply _not_ implement that interface, rather than returning an error at runtime. - Document that `connect` may return ECONNABORTED - Document the set of socket options that are inherited through `accept` - Clarify `connect` failure state: ```md POSIX mentions: > If connect() fails, the state of the socket is unspecified. Conforming applications should > close the file descriptor and create a new socket before attempting to reconnect. WASI prescribes the following behavior: - If `connect` fails because an input/state validation error, the socket should remain usable. - If a connection was actually attempted but failed, the socket should become unusable for further network communication. ``` - Clarify `local-address` behavior on unbound socket: ```md POSIX mentions: > If the socket has not been bound to a local name, the value > stored in the object pointed to by `address` is unspecified. WASI is stricter and requires `local-address` to return `not-bound` when the socket hasn't been bound yet. ``` - Remove TCP_NODELAY for the time being. The semantics of TCP_NODELAY (and TCP_CORK for that matter) and its effects on the output-stream needs to investigated and specified. I don't expect there to be anything insurmountable. Its just that I haven't had the time to do so yet and I can't promise to have it done before the stabilization Preview2. So, in order to get wasi-sockets ready for Preview2, it was discussed to temporarily remove `no-delay` and reevaluate its inclusion before Preview3. - Introduce new `incoming-datagram-stream` and `outgoing-datagram-stream` types and moved `receive` and `send` methods to those respectively. These streams are returned by `stream` and can be individually subscribed to. This resolves a design issue where a UDP server would end up in a spin loop because `receive` returned EWOULDBLOCK but poll_* always returned immediately because the socket was ready for sending. In this new setup, users can poll each direction separately. Fixes WebAssembly#64 - Dropped the `network` parameter from the `connect` call, because `bind` is now _required_ to perform IO. - Enable send-like behaviour by making `outgoing-datagram::remote-address` optional. Fixes WebAssembly#57 - Remove the non-essential parameters for now. Post-preview2 these can be reevaluated again. - Lift the restriction against parsing IP addresses. Before, implementations still needed to parse IP addresses to decide whether or not to return an error.
badeend
force-pushed
the
sync-wasmtime-changes
branch
from
November 8, 2023 14:46
bc6c19a
to
7f1234e
Compare
- Add support for the socket options: - `is-listening` (`SO_ACCEPTCONN`) - `keep-alive-count` (`TCP_KEEPCNT`) - `keep-alive-idle-time` (`TCP_KEEPIDLE`) - `keep-alive-interval` (`TCP_KEEPINTVL`) - Tweak existing socket options: - Rename `keep-alive` to `keep-alive-enabled`, since it is no longer the only "keep-alive"-related option. - Rename `(set-)unicast-hop-limit` to `(set-)hop-limit`, because the "unicast" qualifier is redundant for TCP. - Be stricter in that `0` is not a valid value for: - `set-listen-backlog-size` - `set-hop-limit` - `set-receive-buffer-size` - `set-send-buffer-size`
This was referenced Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP
accept()
to return transient errors.The original provision was added to align with preview3 streams that may only fail once. However, after discussing with Dan Gohman, we came to the conclusion that a
stream
ofresult<>
could do the trick fine too.Fixes: How to report
ECONNABORTED
errors fromaccept
? #22ephemeral-ports-exhausted
intoaddress-in-use
. There is no cross-platform way to know the distinction between them.concurrency-conflict
clutter,and just document it to be always possible.
There is a myriad of reasons why an argument might be invalid or an operation might be not supported. But there is few cross platform consistency in which of those error cases result in which error codes. Many wasi-sockets codes were unnecessarily detailed and had no standardized equivalent in POSIX, so wasi-libc will probably just map them all back into a single EOPNOTSUPP or EINVAL or ...
These stem from back when the entire wasi-sockets proposal was one big single thing. In this day and age, when an implementation doesn't want to support TCP and/or UDP, it can simply not implement that interface, rather than returning an error at runtime.
connect
may return ECONNABORTEDaccept
connect
failure state:local-address
behavior on unbound socket:no-delay
and reevaluate its inclusion before Preview3.is-listening
(SO_ACCEPTCONN
)keep-alive-count
(TCP_KEEPCNT
)keep-alive-idle-time
(TCP_KEEPIDLE
)keep-alive-interval
(TCP_KEEPINTVL
)keep-alive
tokeep-alive-enabled
, since it is no longer the only "keep-alive"-related option.(set-)unicast-hop-limit
to(set-)hop-limit
, because the "unicast" qualifier is redundant for TCP.set-listen-backlog-size
set-hop-limit
set-receive-buffer-size
set-send-buffer-size
UDP
incoming-datagram-stream
andoutgoing-datagram-stream
types and movedreceive
andsend
methods to those respectively. These streams are returned bystream
and can be individually subscribed to. This resolves a design issue where a UDP server would end up in a spin loop becausereceive
returned EWOULDBLOCK but poll_* always returned immediately because the socket was ready for sending. In this new setup, users can poll each direction separately. Fixes UDP subscribe can't be split between read/write #64network
parameter from theconnect
call, becausebind
is now required to perform IO.outgoing-datagram::remote-address
optional. Fixes UDP: Enablesend
-like behaviour #57set-unicast-hop-limit
set-receive-buffer-size
set-send-buffer-size
IP name lookup