Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Commit

Permalink
Avoid libtinfo specifically on linux, where we are seeing issues (#541)
Browse files Browse the repository at this point in the history
As not having it removes colors on some systems. Oddly on one machine I didn't see this, but testing on another, I do - all the colors are gone.

The eventual solution may be to statically link libtinfo. Meanwhile with it we get errors on some linuxes but proper colors, and without it we avoid linux errors but have no colors. With this PR at least the loss of colors is just on linux.

See

emscripten-core/emsdk#252

#539

#540
  • Loading branch information
kripken authored Jun 13, 2019
1 parent ee1cb39 commit 58e343a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ def LLVM():
'-DLLVM_ENABLE_PROJECTS=lld;clang',
# linking libtinfo dynamically causes problems on some linuxes,
# https://github.com/emscripten-core/emsdk/issues/252
'-DLLVM_ENABLE_TERMINFO=0',
'-DLLVM_ENABLE_TERMINFO=%d' % (not IsLinux()),
])

jobs = host_toolchains.NinjaJobs()
Expand Down Expand Up @@ -961,7 +961,7 @@ def Fastcomp():
'-DLLVM_ENABLE_ASSERTIONS=ON',
# linking libtinfo dynamically causes problems on some linuxes,
# https://github.com/emscripten-core/emsdk/issues/252
'-DLLVM_ENABLE_TERMINFO=0',
'-DLLVM_ENABLE_TERMINFO=%d' % (not IsLinux()),
('-DLLVM_EXTERNAL_CLANG_SOURCE_DIR=%s' %
GetSrcDir('emscripten-fastcomp-clang'))
])
Expand Down

0 comments on commit 58e343a

Please sign in to comment.