Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ErrorEvent against AudioWorkletNode.onprocessorerror #2003

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Use ErrorEvent against AudioWorkletNode.onprocessorerror #2003

merged 3 commits into from
Jul 19, 2019

Conversation

hoch
Copy link
Member

@hoch hoch commented Jul 18, 2019 •
edited by pr-preview bot
Loading

Fixes #1984 based on #1984 (comment).

Preview | Diff

@hoch hoch requested a review from padenot July 18, 2019 17:00
@hoch hoch changed the title Use ErrorEvent agains AudioWorkletNode.onprocessorerror Use ErrorEvent against AudioWorkletNode.onprocessorerror Jul 18, 2019
padenot
padenot reviewed Jul 19, 2019
View reviewed changes
index.bs Outdated Show resolved Hide resolved
padenot
padenot reviewed Jul 19, 2019
View reviewed changes
index.bs Show resolved Hide resolved
padenot
padenot approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but see the comments.

@hoch hoch merged commit 31a8116 into WebAudio:master Jul 19, 2019
@hoch hoch deleted the 1984-handling-exception-audio-worklet branch March 10, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padenot padenot padenot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling of exceptions in audio worklet is not very clear
2 participants
@hoch @padenot