Split the instantiation algorithm of AWN/AWP into each constructor #2005
Conversation
index.bs
Outdated
| following steps on the control thread, where the constructor was | ||
| called. | ||
|
|
||
| 1. Perform the validity check on <var>options</var>. If the |
There was a problem hiding this comment.
What does "the validity check" refer to?
There was a problem hiding this comment.
This is one of TODO items, based on #1969. I have to plan to address this with a follow-up PR.
| <dl dfn-type="constructor" dfn-for="AudioWorkletProcessor"> | ||
| : <dfn>AudioWorkletProcessor(options)</dfn> | ||
| :: | ||
| When the constructor for {{AudioWorkletProcessor}} is invoked, the following steps are performed: | ||
| When the constructor for {{AudioWorkletProcessor}} is invoked, | ||
| the following steps are performed on the <a>rendering thread</a>. |
There was a problem hiding this comment.
Is this mandatory ? It would be best if this was not done on an RT thread, right?
There was a problem hiding this comment.
Hmm. AudioWorkletProcessor belongs to the rendering thread. How would you use this object if this is created in somewhere else? Are you creating this from the control and transfer it?
There was a problem hiding this comment.
If you want to have the flexibility of "construction", you might want to create a follow-up PR after this one.
| When the constructor for {{AudioWorkletProcessor}} is invoked, the following steps are performed: | ||
| When the constructor for {{AudioWorkletProcessor}} is invoked, | ||
| the following steps are performed on the <a>rendering thread</a>. | ||
|
|
There was a problem hiding this comment.
This is basically a move of the existing algorithm from another section to this, right? No other changes?
There was a problem hiding this comment.
It depends on what your "this" means here. This PR has few more changes integrated. I summarized them in the description.
But if you're asking about this L.10147 specifically - Yes. It's a simple move.
PTAL - I would like to tackle this over multiple commits. Some changes are coupled tightly, so it's hard to break down.
DONE
AWP.portexplicitly (VUMeter example uses AudioWorkletProcessor's port in a way that can't work per spec #1973)NewTargetandactive function objectbit (NewTarget check for AudioWorkletProcessor isn't actually possible with a Web IDL constructor #1963)parameterDescriptorinAudioWorkletNodeconstructor. (parameterDescriptors handling during AudioWorkletNode initialization is probably wrong #1972)Preview | Diff