Check the Write property when calling WriteValue on characteristic #248
Conversation
| @@ -3281,6 +3281,8 @@ <h3 class="heading settled dfn-paneled idl-code" data-dfn-type="interface" data- | |||
| <li> | |||
| Return a <code>this.service.device.gatt</code>-<a data-link-type="dfn" href="#connection-checking-wrapper" id="ref-for-connection-checking-wrapper-3">connection-checking wrapper</a> around <a data-link-type="dfn" href="https://www.w3.org/2001/tag/doc/promises-guide/#a-new-promise">a new promise</a> <var>promise</var> and run the following steps in parallel. | |||
| <ol> | |||
| <li> If the <code>Write</code> bit is not set | |||
There was a problem hiding this comment.
Please update index.bs instead of index.html. index.html is built from index.bs using https://api.csswg.org/bikeshed/, so if you only change index.html, we'll lose your change on the next build.
There was a problem hiding this comment.
We should allow the write if any of Write, Write Without Response, or Authenticated Signed Writes is set.
|
Thanks for the change! Could I double-check that you've joined https://www.w3.org/community/web-bluetooth/ (which records your agreement to https://www.w3.org/community/about/agreements/cla/) so we can use your contribution? Sorry for the legal hurdle. |
|
Thanks for the advices. I have send my join request to the community, and currently waiting for the answer. Also I have updated the index.bs file. |
|
@jyasskin I have successfully joined the community group. Could you please review my PR? |
|
Thanks! |
Preview at https://rawgit.com/zakorgy/web-bluetooth/characteristic-writevalue/index.html#dom-bluetoothremotegattcharacteristic-writevalue.
This fixes #247.