Fix compatibility with nette/application 3.2.3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old name was super confusing.
To be enforced in the next commit.
nette/application@850ab85 moved link generation to a new LinkGenerator class that must be instantiated or creating links will fail: Unable to create link to other presenter, service PresenterFactory or Router has not been set. In order for LinkGenerator to be instantiated, we need to pass a IPresenterFactory when instantiating a Presenter. Let’s make our PresenterFactory trivially implement the interface so that it can be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nette/application@850ab85 moved link generation to a new LinkGenerator class that must be instantiated or creating links will fail:
In order for LinkGenerator to be instantiated, we need to pass a IPresenterFactory when instantiating a Presenter.
Let’s make our PresenterFactory trivially implement the interface so that it can be used.
Also apply some cleanups.