C++_2 #7
Open
C++_2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First Cut made * Insert done. Refractoring to be done * Remove implemented * Access code done. * Testing skeleton code added * Code restart * LFU Testing done! * Todos Removed * Refractoring * Changes and Cpp Unit Tests Added. * Source files added * Cmake files removed
mohitreddy1996
suggested changes
Sep 23, 2017
There was a problem hiding this comment.
- Create a .h class to define the necessary classes.
For the same header file, create a .cc file and implement all the necessary member funtions in that. - _main.cpp is not required. Use unit testing to test the functionality of the program. And refer to testcases.md for the tests for which the program should pass.
- Follow a coding convention through out. Name a function/class/struct in camel cases. variable names separated by '_'.
- Add required comments.
Good example to get started with test suite.
CPPUnit testing: http://cppunit.sourceforge.net/doc/cvs/money_example.html
Good first attempt. Didnt check the functionality. Once the changes are made, second review will be done. Thanks,
mohitreddy1996
suggested changes
Sep 23, 2017
|
Any other changes required? @mohitreddy1996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of LFU Cache, using C++