Update Source Path Mapping for case sensitivity. #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SSH path mapping, the unmapped portion of the path will retain its case, so that mapping to file systems which are case sensitive will work as expected. Furthermore, additional functionality has been added, such as proper detection and handling of overlapping paths. Additionally, the source file mapping and path handling functionality has been moved to their own files to improve cohesion and better support unit testing. Unit tests have been added for source file mapping as well as path functionality.
brownts
force-pushed
the
bugfix/ssh_path_mapping
branch
from
606c369
to
8590543
Compare
brownts
changed the title
|
Thanks for taking the time to split that out and adding the unit tests. |
|
Just wondering: Should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346.
For SSH path mapping, the unmapped portion of the path will retain its
case, so that mapping to file systems which are case sensitive will work
as expected. Furthermore, additional functionality has been added, such
as proper detection and handling of overlapping paths.
Additionally, the source file mapping and path handling functionality
has been moved to their own files to improve cohesion and better support
unit testing. Unit tests have been added for source file mapping as
well as path functionality.