set "noImplicitAny" to true and fix the problems #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 20.47% 20.47%
=======================================
Files 14 14
Lines 1807 1807
Branches 391 392 +1
=======================================
Hits 370 370
Misses 1392 1392
Partials 45 45 ☔ View full report in Codecov by Sentry. |
WebFreak001
reviewed
Apr 4, 2024
| @@ -223,7 +224,7 @@ export function expandValue(variableCreate: Function, value: string, root: strin | |||
| val = "Object@" + val; | |||
| } | |||
| } else if (typeof val == "string" && val.startsWith("@0x")) { | |||
| ref = variableCreate(getNamespace("*&" + name.substr)); | |||
| ref = variableCreate(getNamespace("*&" + name.substring(1))); | |||
There was a problem hiding this comment.
ah nice catch, do you know why you remove the first character here? It looks like maybe just passing name instead might be correct instead. Sadly there is no test for this to actually verify this.
There was a problem hiding this comment.
That was just a guess. Feel free to change it.
WebFreak001
approved these changes
Apr 4, 2024
|
I'm eager to see the rest of the patch series 💪 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some work on code-debug. This is a first PR in a series. I set
noImplicitAnyto true and fixed the problems. I also found a bug ingdb_expansion.tsline 226. Not sure if I fixed it correctly.