-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set "noImplicitAny" to true and fix the problems #419
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 20.47% 20.47%
=======================================
Files 14 14
Lines 1807 1807
Branches 391 392 +1
=======================================
Hits 370 370
Misses 1392 1392
Partials 45 45 ☔ View full report in Codecov by Sentry. |
@@ -223,7 +224,7 @@ export function expandValue(variableCreate: Function, value: string, root: strin | |||
val = "Object@" + val; | |||
} | |||
} else if (typeof val == "string" && val.startsWith("@0x")) { | |||
ref = variableCreate(getNamespace("*&" + name.substr)); | |||
ref = variableCreate(getNamespace("*&" + name.substring(1))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nice catch, do you know why you remove the first character here? It looks like maybe just passing name
instead might be correct instead. Sadly there is no test for this to actually verify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was just a guess. Feel free to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! Thank you very much for these much needed improvements
I'm eager to see the rest of the patch series 💪 . |
I did some work on code-debug. This is a first PR in a series. I set
noImplicitAny
to true and fixed the problems. I also found a bug ingdb_expansion.ts
line 226. Not sure if I fixed it correctly.