support for Base64.getDecoder().decode(String) #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Oct 18, 2023
| return Base64.Decoder.class; | ||
| } | ||
|
|
||
| private final static String BASE64_REGEX = "^[A-Za-z0-9+/]+={0,2}$"; |
There was a problem hiding this comment.
if this is coming from somewhere, best to put a link here as well
There was a problem hiding this comment.
I found a better regex for this. I am also adding the link to the source.
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| public class Base64DecoderClassReplacementTest { |
There was a problem hiding this comment.
would be good to have a simple E2E as well.
for example, i think this will not work right now, as it is not registered on ReplacementList
There was a problem hiding this comment.
You're right. I was just checking with EMB why the error message kept happening.
I will add the e2e test too.
Thxs!
arcuri82
requested changes
Oct 20, 2023
| @@ -68,7 +68,8 @@ public static List<MethodReplacementClass> getList() { | |||
| new URLClassReplacement(), | |||
| new UUIDClassReplacement(), | |||
| new ValidatorClassReplacement(), | |||
| new WebRequestClassReplacement() | |||
| new WebRequestClassReplacement(), | |||
| new Base64DecoderClassReplacement() | |||
There was a problem hiding this comment.
list should be kept in alphabetic order
arcuri82
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.