Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove habname from exchange query #128

Merged

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Nov 16, 2023

Suggestion to resolve #127

See issue for rationale.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56c20c7) 91.66% compared to head (316d79b) 91.69%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #128      +/-   ##
===============================================
+ Coverage        91.66%   91.69%   +0.02%     
===============================================
  Files               37       37              
  Lines             5987     5981       -6     
===============================================
- Hits              5488     5484       -4     
+ Misses             499      497       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan marked this pull request as ready for review November 16, 2023 16:00
@lenkan
Copy link
Collaborator Author

lenkan commented Nov 16, 2023

We could also consider changing the POST /identifiers/{name}/exchanges to POST /exchanges and put the name parameter as part of the body. That would make it more coherent, but probably has more implications than I know of.

@lenkan
Copy link
Collaborator Author

lenkan commented Nov 20, 2023

@pfeairheller Have you had a chance to look at this?

@pfeairheller
Copy link
Member

@pfeairheller Have you had a chance to look at this?

Yes, just waited until this morning when I had a chance to update the SigPy client before merging.

@pfeairheller pfeairheller merged commit 843759f into WebOfTrust:development Nov 20, 2023
5 checks passed
@lenkan lenkan deleted the remove-habname-from-exchange-query branch September 2, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get recipient of a notification message
2 participants