Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings for OpenApi documentation for keria rest endpoints #252

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

rubelhassan
Copy link
Contributor

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (caad67b) to head (7d73870).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   92.82%   93.02%   +0.19%     
==========================================
  Files          37       36       -1     
  Lines        6982     6992      +10     
==========================================
+ Hits         6481     6504      +23     
+ Misses        501      488      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pfeairheller pfeairheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of good work and represents a big improvement for KERIA and the API documentation!

@pfeairheller pfeairheller merged commit 6702a30 into WebOfTrust:main Jun 6, 2024
5 checks passed
@rubelhassan rubelhassan deleted the issue-251 branch June 11, 2024 09:48
pfeairheller pushed a commit that referenced this pull request Jun 13, 2024
* improved design and logic per review comments, still need to track the dip process by the delegator

Signed-off-by: 2byrds <2byrds@gmail.com>

* delegator endpoint processes dip as a long running processes. tests pass

Signed-off-by: 2byrds <2byrds@gmail.com>

* small fixes to op checks

Signed-off-by: 2byrds <2byrds@gmail.com>

* small fixes on checking dip success

Signed-off-by: 2byrds <2byrds@gmail.com>

* remove unnecessary loop for interact operation

Signed-off-by: 2byrds <2byrds@gmail.com>

* point to keri main for now, will use 1.2.0-dev5 when it's available

Signed-off-by: 2byrds <2byrds@gmail.com>

* refactored degator end to delegating.py and corresponding tests and used credentialing design for IdentifierResource end usage

Signed-off-by: 2byrds <2byrds@gmail.com>

* consolidate to optype of 'delegation' and clean up tests

Signed-off-by: 2byrds <2byrds@gmail.com>

* improve naming to be consistent with credentialing, and tested with signify-ts delegation updates

Signed-off-by: 2byrds <2byrds@gmail.com>

* Add docstrings for OpenApi documentation for keria rest endpoints (#252)

* Add docstrings for OpenApi documentation for keria rest endpoints

* Uncomment operation resource end

* Fix specing test

---------

Co-authored-by: Rubel Hassan Mollik <rubel.hassan@outlook.com>

* Add more keria rest endpoints docs (#253)

Co-authored-by: Rubel Hassan Mollik <rubel.hassan@outlook.com>

* improved design and logic per review comments, still need to track the dip process by the delegator

Signed-off-by: 2byrds <2byrds@gmail.com>

* delegator endpoint processes dip as a long running processes. tests pass

Signed-off-by: 2byrds <2byrds@gmail.com>

* small fixes to op checks

Signed-off-by: 2byrds <2byrds@gmail.com>

* small fixes on checking dip success

Signed-off-by: 2byrds <2byrds@gmail.com>

* remove unnecessary loop for interact operation

Signed-off-by: 2byrds <2byrds@gmail.com>

* point to keri main for now, will use 1.2.0-dev5 when it's available

Signed-off-by: 2byrds <2byrds@gmail.com>

* refactored degator end to delegating.py and corresponding tests and used credentialing design for IdentifierResource end usage

Signed-off-by: 2byrds <2byrds@gmail.com>

* consolidate to optype of 'delegation' and clean up tests

Signed-off-by: 2byrds <2byrds@gmail.com>

* improve naming to be consistent with credentialing, and tested with signify-ts delegation updates

Signed-off-by: 2byrds <2byrds@gmail.com>

* recovering test_spec changes for delegation after rebase

Signed-off-by: 2byrds <2byrds@gmail.com>

* update tests with latest keripy changes, digests/versions changed

Signed-off-by: 2byrds <2byrds@gmail.com>

---------

Signed-off-by: 2byrds <2byrds@gmail.com>
Co-authored-by: Rubel Hassan <rubelhassan@outlook.com>
Co-authored-by: Rubel Hassan Mollik <rubel.hassan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants