Make agent doers' tocks configurable from habitat config file #265
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 93.06% 93.10% +0.04%
==========================================
Files 36 36
Lines 7121 7221 +100
==========================================
+ Hits 6627 6723 +96
- Misses 494 498 +4 ☔ View full report in Codecov by Sentry. |
|
@rubelhassan LGTM. if you were able to successfully run the signify-ts integration scripts against a keria with these changes I'll approve it. |
| @@ -289,6 +290,8 @@ def __init__(self, hby, rgy, agentHab, agency, caid, **opts): | |||
| self.agentHab = agentHab | |||
| self.agency = agency | |||
| self.caid = caid | |||
| self.cfd = MappingProxyType(dict(self.hby.cf.get()) if self.hby.cf is not None else dict()) | |||
There was a problem hiding this comment.
Why do we need MappingProxyType here instead of accessing the dict directly?
There was a problem hiding this comment.
I've used it to make the dict immutable, so it cannot be changed unintentionally.
|
I just resolved the conflicts with main for this PR. Once it builds I'll merge it. |
Thank you, I was about update the PR :) |
…rust#265) * Make agent doers' tocks configurable from habitat config file * Fix typo of naming in test_load_tocks_config --------- Co-authored-by: Rubel Hassan Mollik <rubel.hassan@outlook.com> Co-authored-by: Philip Feairheller <pfeairheller@gmail.com>
#258