-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing prefixes in identifiers endpoint (resubmitted PR) #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 93.06% 93.17% +0.11%
==========================================
Files 36 36
Lines 7121 7741 +620
==========================================
+ Hits 6627 7213 +586
- Misses 494 528 +34 ☔ View full report in Codecov by Sentry. |
2byrds
approved these changes
Aug 21, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is resubmitted version of the canceled #264
It's is an implementation of #217 and #202, fixing the problem of aliases with special characters .
The changes allow endpoints of the form
/identifiers/{name}
to accept an alias or a prefix in the name path. If the value is valid for both prefix and alias, the prefix is prioritized.Basically, the PR replace:
hab = agent.hby.habByName(name)
with
hab = agent.hby.habs[name] if name in agent.hby.habs else agent.hby.habByName(name)