Feat/submit

[2byrds]

Adds a KERIA endpoint /identifiers/${name}/submit to resubmit an identifier KEL to be receipted by it's witnesses.
Adds 'submit' unit tests
This feature is the KERIA equivalent to the keripy witness 'submit' command line tool

[2byrds]

self-review in order to 'mark' the changes in the midst of many formatting changes.

[pfeairheller]

This PR will not be accepted with formatting changes, and as a general open source software contribution practice formatting changes should never be included in PRs that address features or bug fixes. In addition formatting changes that cause files to differ from each other in the same repo should not be submitted.

Please resubmit without the mass reformatting of files so we can review the actual changes.

[pfeairheller]

self-review in order to 'mark' the changes in the midst of many formatting changes.

Being perfectly frank here, this stands out as a red flag. It would be irresponsible as maintainers of a security focused open source project to accept a PR with this many changes that the submitter is asking us to ignore. And the changes are not appropriate for the bug being fixed and the amount of reformatting makes it very hard to determine what was actually changed.

PRs should be laser focused on what they are fixing. If we want to reformat the Python, that should be discussed, an issue open and a systematic approach taken.

[2byrds]

@pfeairheller do you know what formatter you use so I can change my auto-formatter. It's a useful IDE tool so if I can align with you that would be ideal.

[2byrds]

@pfeairheller signify-ts has a github action that checks formatting for all PRs. are you open to a similar github action in KERIA so that formatting is aligned and enforced?

[2byrds]

self-review in order to 'mark' the changes in the midst of many formatting changes.

Being perfectly frank here, this stands out as a red flag. It would be irresponsible as maintainers of a security focused open source project to accept a PR with this many changes that the submitter is asking us to ignore. And the changes are not appropriate for the bug being fixed and the amount of reformatting makes it very hard to determine what was actually changed.

PRs should be laser focused on what they are fixing. If we want to reformat the Python, that should be discussed, an issue open and a systematic approach taken.

Great!
I don't know what you mean by the changes are not appropriate for the bug being fixed. It is introducing a feature that is similar to the keripy feature.
As for formatting i'll create a test PR that standardizes the format and introduces a format check. If you would like to be the one to submit the reformatted repo so that it is attributed to a maintainer that is cool with me.
Then we'll be well formatted, aligned, and all future PRs enforced.

[2byrds]

@pfeairheller here is a draft PR to add the github action for checking python via 'black'.
#273
I have no preference on the formatter we use, this is a common one.
You can see the diagnostic output of the check here https://github.com/WebOfTrust/keria/pull/273/checks
perhaps you will want to submit the PR as a maintainer with the reformatted repo.

pip install black

black --check .

black .

and once the formatting is aligned i will update this PR to align (all PRs will be forced to align from now on).

[pfeairheller]

@pfeairheller do you know what formatter you use so I can change my auto-formatter. It's a useful IDE tool so if I can align with you that would be ideal.

I use IntelliJ's support for the PEP formatting rules.

[pfeairheller]

@pfeairheller here is a draft PR to add the github action for checking python via 'black'. #273 I have no preference on the formatter we use, this is a common one. You can see the diagnostic output of the check here https://github.com/WebOfTrust/keria/pull/273/checks perhaps you will want to submit the PR as a maintainer with the reformatted repo.

pip install black

black --check .

black .

and once the formatting is aligned i will update this PR to align (all PRs will be forced to align from now on).

I believe the signify-ts only does format checking, not reformatting. Something I've run afoul of, having to push changes to PRs because they failed the check. I'd like to take that approach here and not one that changes the code automatically.

[2byrds]

@pfeairheller here is a draft PR to add the github action for checking python via 'black'. #273 I have no preference on the formatter we use, this is a common one. You can see the diagnostic output of the check here https://github.com/WebOfTrust/keria/pull/273/checks perhaps you will want to submit the PR as a maintainer with the reformatted repo.

pip install black

black --check .

black .

and once the formatting is aligned i will update this PR to align (all PRs will be forced to align from now on).

I believe the signify-ts only does format checking, not reformatting. Something I've run afoul of, having to push changes to PRs because they failed the check. I'd like to take that approach here and not one that changes the code automatically.

I agree. I found that out earlier (changing the formatting is overkill) and changed the PR to only do the check

[2byrds]

This PR will not be accepted with formatting changes, and as a general open source software contribution practice formatting changes should never be included in PRs that address features or bug fixes. In addition formatting changes that cause files to differ from each other in the same repo should not be submitted.

Please resubmit without the mass reformatting of files so we can review the actual changes.

@pfeairheller I have updated the sections of code that had formatting issues.