Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass through salts for vc create to facilitate command line multisig #902

Merged
merged 2 commits into from
Dec 13, 2024
Merged

pass through salts for vc create to facilitate command line multisig #902

merged 2 commits into from
Dec 13, 2024

Conversation

m00sey
Copy link
Member

@m00sey m00sey commented Dec 10, 2024

No description provided.

@m00sey
pass through salts for vc create to facilitate command line multisig
26c384a 
Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
@m00sey
updates type hints for all
6063ab4 
Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
pfeairheller
pfeairheller approved these changes Dec 13, 2024
View reviewed changes
src/keri/vc/proving.py Show resolved Hide resolved
@m00sey m00sey merged commit b35fee7 into main Dec 13, 2024
6 checks passed
@m00sey m00sey deleted the enc/pass-through-credential-salts branch December 13, 2024 21:55
@kentbull
Copy link
Contributor

Looks like the store_true in the two new command line arguments --private-credential-nonce and --private-subject-nonce here should have had their "action" prop set to store so that they can accept string values rather than be set only to True or False based on presence or absence of the command line arguments like --private.

I'll fix this in a PR.

@kentbull kentbull mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeairheller pfeairheller pfeairheller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m00sey @kentbull @pfeairheller