generic-sensors-adapter: Update to v0.0.10 #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forwarded: WebThingsIO#650 Bug: rzr/generic-sensors-webthings#11 Relate-to: WebThingsIO#54 Change-Id: I576648a50ba66abe91688359abdfa281a0ae63fa Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
9cea299 to
8ec8ec6
Compare
|
Thanks for taking care of this! Would you have a problem with me pulling this into the addon-builder, so that we can get builds for Node 10 and 12 as well? This is one of 4 remaining add-ons that will only work with Node 8. |
|
I can do that or if you want to, go ahead, node 10 should work using the updated @abandonware i2c module Anyway I will probably a new version before next release |
|
Ok, I'll go ahead and merge this PR and then will try to add it to the addon-builder. |
mrstegeman
approved these changes
Jan 15, 2020
rzr
added a commit
to CrossStream/addon-builder
that referenced
this pull request
Jan 15, 2020
Change-Id: I072c5ce6005a27fbc6a8229ed82257eba6ec64c1 Forwarded: https://github.com/mozilla-iot/addon-builder/pulls Relate-to: WebThingsIO/addon-list#650 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
added a commit
to CrossStream/addon-builder
that referenced
this pull request
Jan 15, 2020
Change-Id: I996287cec08dc1af2edc7f0bb1fe090027e1e579 Forwarded: https://github.com/mozilla-iot/addon-builder/pulls Relate-to: WebThingsIO/addon-list#650 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
added a commit
to CrossStream/addon-builder
that referenced
this pull request
Jan 15, 2020
Change-Id: I072c5ce6005a27fbc6a8229ed82257eba6ec64c1 Forwarded: https://github.com/mozilla-iot/addon-builder/pulls/42 Relate-to: WebThingsIO/addon-list#650 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
added a commit
to CrossStream/addon-builder
that referenced
this pull request
Jan 15, 2020
Change-Id: I996287cec08dc1af2edc7f0bb1fe090027e1e579 Forwarded: https://github.com/mozilla-iot/addon-builder/pulls/42 Relate-to: WebThingsIO/addon-list#650 Signed-off-by: Philippe Coval <rzr@users.sf.net>
mrstegeman
pushed a commit
to WebThingsIO/addon-builder
that referenced
this pull request
Jan 15, 2020
* generic-sensors-adapter: Add gitmodule Change-Id: I072c5ce6005a27fbc6a8229ed82257eba6ec64c1 Forwarded: https://github.com/mozilla-iot/addon-builder/pulls/42 Relate-to: WebThingsIO/addon-list#650 Signed-off-by: Philippe Coval <rzr@users.sf.net> * generic-sensors-adapter: Add to build-addons.sh Change-Id: I996287cec08dc1af2edc7f0bb1fe090027e1e579 Forwarded: https://github.com/mozilla-iot/addon-builder/pulls/42 Relate-to: WebThingsIO/addon-list#650 Signed-off-by: Philippe Coval <rzr@users.sf.net>
|
I just opened a PR, to use builder, but I might have missed other steps, any documentation I should look at: |
|
You can not trigger an actual release build, only I can. So you’ll just have to let me know when you’re ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: rzr/generic-sensors-webthings#11
Relate-to: #54
Change-Id: I576648a50ba66abe91688359abdfa281a0ae63fa
Signed-off-by: Philippe Coval rzr@users.sf.net