Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update license notice #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Panquesito7
Copy link
Member

Related Issue

#6.

Describe the changes you've made

  • Update license notice.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

I don't think this applies here.

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@Panquesito7 Panquesito7 added the documentation Improvements or additions to documentation label Nov 25, 2021
Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1: This is not a Markdown file for a # heading
2: I think we just need to add the image as per the website docs
3: I think noncommercial-no derivatives is a good license.

@Panquesito7
Copy link
Member Author

1: This is not a Markdown file for a # heading 2: I think we just need to add the image as per the website docs 3: I think noncommercial-no derivatives is a good license.

  1. Forgot to update the file's format.
  2. What do you mean by "image"?
  3. Why do you think that? I don't think it won't harm if others use it for commercial use and modify it?

We can discuss this further on Discord as well. @vinzvinci, thoughts?

@gptkrsh
Copy link

gptkrsh commented Nov 26, 2021

  1. What do you mean by "image"?

The CC rectangle? The docs just ask you to add that or a link to the license in the text. Also adding a license there would also disable the github formatting on the sidebar

  1. Why do you think that? I don't think it won't harm if others use it for commercial use and modify it?

All rights of the article submitted shall be to the author, people can use it but with permission from the author 🙂

@Panquesito7
Copy link
Member Author

  1. Why do you think that? I don't think it won't harm if others use it for commercial use and modify it?

All rights of the article submitted shall be to the author, people can use it but with permission from the author 🙂

That would break the CC BY-NC-ND 4.0 guidelines as well, AFAIK.

https://creativecommons.org/licenses/by-nc-nd/4.0/ here it specifically says that you can't modify it, regardless you have permission from the author or not.

What do you mean by "image"?

The CC rectangle? The docs just ask you to add that or a link to the license in the text. Also adding a license there would also disable the github formatting on the sidebar

The GitHub formatting on the sidebar doesn't matter much, IMO. People can check the license easily.
For the CC image, we can add that in this PR if you want. 🙂

@gptkrsh
Copy link

gptkrsh commented Nov 26, 2021

  1. Why do you think that? I don't think it won't harm if others use it for commercial use and modify it?

All rights of the article submitted shall be to the author, people can use it but with permission from the author 🙂

That would break the CC BY-NC-ND 4.0 guidelines as well, AFAIK.

https://creativecommons.org/licenses/by-nc-nd/4.0/ here it specifically says that you can't modify it, regardless you have permission from the author or not.

What do you mean by "image"?

The CC rectangle? The docs just ask you to add that or a link to the license in the text. Also adding a license there would also disable the github formatting on the sidebar

The GitHub formatting on the sidebar doesn't matter much, IMO. People can check the license easily. For the CC image, we can add that in this PR if you want. 🙂

The license can't overthrow the person who applied the license, it is the person who decides the fate of their content. Plus, I think we don't need that text in the license. We can discuss with @vinzvinci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants