Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicked markup not saved in Zen #5049

Closed
comradekingu opened this issue Dec 15, 2020 · 5 comments · Fixed by #5158
Closed

Clicked markup not saved in Zen #5049

comradekingu opened this issue Dec 15, 2020 · 5 comments · Fixed by #5158
Assignees
@nijel
Labels
bug Something is broken.
Milestone
4.5

Comments

@comradekingu
Copy link
Contributor

comradekingu commented Dec 15, 2020 •
edited
Loading

https://hosted.weblate.org/zen/gnucash/gnucash/nb_NO/?q=check:xml-invalid

Click the end or opening bold's and tab to the next string.
If the only change, or the last change is editing in the markup by clicking, it doesn't save.

Typing in <-/-b->-tab works.
@comradekingu comradekingu changed the title Clicked markup doesn't save in Zen Clicked markup not saved in Zen Dec 15, 2020
@nijel nijel added this to the 4.4.1 milestone Dec 16, 2020
@nijel nijel added the bug Something is broken. label Dec 16, 2020
@comradekingu comradekingu mentioned this issue Dec 16, 2020
Closed
@nijel nijel mentioned this issue Dec 30, 2020
Closed
@nijel nijel mentioned this issue Jan 7, 2021
Merged
10 tasks
nijel added a commit to nijel/weblate that referenced this issue Jan 7, 2021
@nijel
JS: Revert CodeMirror usage for editing translations
97d7e75 
It has proven to be a wrong decision as that disables in-browser spell
checker.

This reverts the following commits:

* 123340c
* d2e3eef
* 96a7d55
* 6c31d13
* cecbf9c
* fda647c
* 39ed573
* 017d7a8
* f107cdd
* 9a26161
* 4b2197e
* c69238f
* 16a9f87

Fixes WeblateOrg#4977
Fixes WeblateOrg#5114
Fixes WeblateOrg#5049
@kodiakhq kodiakhq bot closed this as completed in #5158 Jan 7, 2021
kodiakhq bot pushed a commit that referenced this issue Jan 7, 2021
@nijel @kodiakhq
JS: Revert CodeMirror usage for editing translations
d263d53 
It has proven to be a wrong decision as that disables in-browser spell
checker.

This reverts the following commits:

* 123340c
* d2e3eef
* 96a7d55
* 6c31d13
* cecbf9c
* fda647c
* 39ed573
* 017d7a8
* f107cdd
* 9a26161
* 4b2197e
* c69238f
* 16a9f87

Fixes #4977
Fixes #5114
Fixes #5049
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel self-assigned this Jan 7, 2021
@comradekingu
Copy link
Contributor Author

@nijel This happens when the markup placeholder is at the end of the string now

@nijel nijel reopened this Feb 2, 2021
@nijel nijel modified the milestones: 4.4.1, 4.5 Feb 2, 2021
@nijel nijel closed this as completed in 10f088f Feb 2, 2021
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@comradekingu
Copy link
Contributor Author

comradekingu commented Feb 14, 2021 •
edited
Loading

Now it throws the error in the dropdown, but it is saved.
Try it with https://hosted.weblate.org/translate/komga/webui/nb_NO/?checksum=e19eb74f6cf0dc4f

Edit: No, I think that is just the general thing of throwing errors as they happen, but a bit strange still for this one since it isn't an actual error.

@nijel
Copy link
Member

nijel commented Feb 15, 2021

What kind of error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
bug Something is broken.
Projects
None yet
Milestone
4.5
Development

Successfully merging a pull request may close this issue.

Use syntax-highlighting textarea instead of CodeMirror nijel/weblate
2 participants
@nijel @comradekingu