Fixed an issue with file validation #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WendellAdriel
previously approved these changes
Feb 5, 2024
|
@vadymtsots thanks for the contribution, just fix the code style issues and it's all good to go! |
WendellAdriel
approved these changes
Feb 5, 2024
|
Thanks for the help with this one @vadymtsots!!! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with uploaded file validation described here: https://github.com/WendellAdriel/laravel-validated-dto/discussions/63
Before validation, an
UploadedFileinstance gets casted to array and passed to Validator. Validator performs ainstance of UploadedFilecheck, and the validation fails, because of this cast to array.The PR adds an additional check to
SimpleDTO'sisArrayable()method, that ensures thatUploadedFileobject is not considered arrayable value and it will not be passed toformatArrayableValue()method for further array casting.Unit tests for file validation were also added.