Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mean and median as imputation methods, and update docs #317

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Mar 19, 2024

What does this PR do?

  1. add Mean and Median;
  2. update the docs;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8340258469

Details

  • 83 of 93 (89.25%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 81.762%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/mean/model.py 37 42 88.1%
pypots/imputation/median/model.py 37 42 88.1%
Files with Coverage Reduction New Missed Lines %
pypots/cli/env.py 1 65.31%
Totals Coverage Status
Change from base Build 8323647996: 0.1%
Covered Lines: 5205
Relevant Lines: 6366

💛 - Coveralls

@WenjieDu WenjieDu merged commit a0470b2 into main Mar 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants