Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MultiHeadAttention #322

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Simplify MultiHeadAttention #322

merged 1 commit into from
Mar 28, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

Refactor and simplify MHA, put dropout, layernorm, and residual connection into EncoderLayer.

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu merged commit 0e727af into dev Mar 28, 2024
4 of 8 checks passed
@coveralls
Copy link
Collaborator

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 8471312563

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 81.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/nn/modules/transformer/layers.py 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
pypots/nn/modules/transformer/layers.py 1 83.67%
pypots/cli/env.py 1 65.31%
Totals Coverage Status
Change from base Build 8448797394: -0.02%
Covered Lines: 5478
Relevant Lines: 6699

💛 - Coveralls

@WenjieDu WenjieDu deleted the (refactor)simplify_mha branch March 28, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants