NoClassDefFoundError on 1.20.6 #330
Comments
|
AnvilGUI version: 1.9.4-SNAPSHOT
|
|
Please see #327, this has been discussed before. You need to ensure that Paper remaps your plugin. Unfortunately there is no way to "tell" Paper to only re-map certain classes (i.e. Anvil-GUI classes). Are you using Paperweight? |
|
I am not using paperweight or any nms related things in those plugins. |
|
Check your server log file that your plugin gets remapped by paper. |
|
Deleted the |
|
What are the contents of the MANIFEST.MF file in your plugin's .jar file? |
|
|
Where is SSCore located? Is it a normal spigot plugin inside the plugins folder? There must be a reason why it doesn't get remapped by Paper. |
|
yes both sccore and scclaims are in plugins folder, they have paper plugin.ymls also i just saw that mentioned in the other issue |
|
Apparently you can't shade the class files of AnvilGUI into a Paper Plugin, it assumes the NMS code to be mojang-mapped, so it doesn't do any remapping, I just asked on their Discord. You can use my gradle version of AnvilGUI tho that has mojang mappings in it: |
|
uhh how exactly? system scope? |
|
by building the jar and shading it into your plugin edit: |
|
I mean, how is this possible? |
|
try this in your pom.xml: <!-- AnvilGUI -->
<dependency>
<groupId>net.wesjd</groupId>
<artifactId>anvilgui</artifactId>
<version>1.9.5-SNAPSHOT</version>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency> |
|
Worked thanks. Are you guys going to publish a separate jar for mojang mappings? |
|
The jar you're using right now (my no-relocation branch) has both mappings in it, so it works on both paper and spigot. I don't know if there is any advantage in distributing two jar files. With both mappings in it, one could target paper and spigot at the same time. I didn't know that these paper plugins were a thing, so I think I will create a PR soon for my fork. Lets leave this issue open until its officially resolved. |
|
@UsainSrht As far as I've understood, you should be able to use the official AnvilGUI version in a Paper plugin as long as you set the Taken from this information in the
The official AnvilGUI version is only compatible with Spigot-mapped plugins, which is why you will need to configure your manifest manually if you are creating a Paper plugin. It's probably worth adding this information to the AnvilGUI README, if this solves your issue. |
|
@UsainSrht did the above solve your issue? if so we should add to README |
|
Helped in my case, thank you! |
|
Yes, adding |
only if your plugin's MANIFEST.MF states that its using Mojang mappings. Otherwise the paper-remapper would automatically remap everything that is not mojang. |
|
Running into this issue aswell, but I am unable to use spigot mappings Is there no real way to use this with a paper plugin and mojang mappings anymore? fork: https://github.com/mineinabyss/AnvilGUI |
No, there is no way to use spigot mappings for paper plugins. The server expects the paper plugin to use mojang mappings. So it needs an AnvilGUI API that has mojang mappings in it. I have a fork of AnvilGUI that has both mojang and spigot mappings in it, which (I think) should work with paper plugins, as mentioned here #330 (comment). |
@Boy0000 Is there a reason why you are unable to use Spigot mappings?
That won't work, for several reasons. The primary reason being that AnvilGUI uses Spigot mappings, which means that the manifest must indicate this or else Paper will not remap the plugin correctly. Switching to Mojang mappings is not as simple as changing a manifest entry. The other reason is that the manifest of a library such as AnvilGUI won't necessarily be included in your plugin (depending on your Maven/Gradle config). In general (and in this case), it makes more sense to edit the manifest of your plugin instead. Because AnvilGUI only supports Spigot mappings, your plugin, and any other libraries you use, must also be using Spigot mappings, and your plugin manifest must indicate this.
This has never been possible, AnvilGUI has always used Spigot mappings. Mojang mappings are only available on modern Minecraft versions, and only on Paper servers. Going through the extra work of supporting both Spigot and Mojang mappings does not seem necessary especially because Paper plugins support using Spigot mappings, by setting
@mastercake10 I don't think this is true at all (see above)? Or have I misunderstood something? See here: https://docs.papermc.io/paper/dev/project-setup#spigot-mappings |
|
All our plugins are paper-plugins and are paper only I do understand why AnvilGUI cant, but in all reality majority of servers are swithing from Spigot Ill look into the fork and see if that solves the problem for me 👍 |
|
@mastercake10 thank you worked perfectly 👍 , just had to add 1.21 compat
|
Yeah, seems like I was wrong. But still why would people want to use spigot mappings in their paper plugin. I think maintaining both spigot and mojang mappings is feasible, since the mojang-mapped class for anvil gui can be reused over versions. |
Then I do understand your concerns, although as far as I know, using Spigot-mapped plugins does not contribute in any significant way to load times, other than the first time you start the server, after which the server can just load cached Mojang-mapped versions of the plugin. Here is what the Paper devs have to say about it:
In regards to the load times, I think maybe you have confused plugin remapping with plugin rewriting? The former was described above, and the latter is a totally different thing which does impact loading times, according to the Paper devs:
Disabling this plugin rewriting is something that AnvilGUI may or may not support (I have not tested it), but that is a different question and the answer will be the same regardless of whether Spigot or Mojang mappings are used.
For compatibility reasons, mostly. Honestly the choice between Spigot and Mojang mappings seems kind of arbitrary to me (from the perspective of the average plugin developer). Sure, if you are working with the server internals, Mojang mappings are great to have, but things can be remapped either way and most people are not working with internals, for good reason.
Fair point, and I do agree that it may be feasible, I just don't think it's very necessary. Even if the Mojang mappings don't change as often, supporting them in addition to the Spigot mappings is extra work and makes the code more complicated. |
|
Maybe consider adding to the README about this, and point out the remapping option and point to a fork for those who cant/wont use spigot mappings? I could probably maintain a fork of @mastercake10 fork on my repo that works with paper-mappings unless he plans to maintainthe one he has on his repo 👍 |
|
I am using my fork in my plugins (the no_relocation branch), so you can expect that I will keep maintaining that fork.
It is necessary to have mojang mappings in the repo, since people are using paper plugins and/or don't want to use spigot mappings. We don't want to rely on the remapper, it takes some time to remap spigot to mojang as Boy0000 mentioned. Supporting two mappings isn't really a problem, we can keep all the "legacy" NMS spigot mapped modules for versions < 1.20.5 and for the NMS modules from 1.20.6 on use the paper mappings. This is what I already do in my fork. It uses the paperweight-userdev gradle plugin, so we can aswell generate a jar file with the spigot-mapped sources using the userdev plugin. This would generate a jar file with everything spigot-mapped. From this point on we can build artifacts containing only spigot mapped classes, only mojang mapped classes and a combination of both. |
Using Paper plugins alone is not a reason to use Mojang mappings, Spigot mappings can still be used in Paper plugins. I mean, I totally get that some might not want to use Spigot mappings, but so far I'm just haven't seen any compelling reason to put in the effort* of maintaining a more complex solution with combined mappings. The time that it takes to remap the plugin seems very negligible to me, especially because it only happens once, and the result is more or less permanently cached after that. * Of course, if someone else is willing to put in that effort, then who am I to complain? Maybe, if we're lucky, there is a future where we don't have to keep maintaining NMS version wrappers. In fact, I think it's fairly likely that it will happen. That would be really nice. Anyways, I submitted a PR to document the Paper remapping stuff, see #345. Let me know if it looks good to you. |
Just upgraded server version and anvilgui and now I can't use it.
Version
This server is running Paper version 1.20.6-112-master@347bbe3 (2024-05-26T22:17:48Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.20.6-90-b149584 (MC: 1.20.6)
Error
Code
The text was updated successfully, but these errors were encountered: