Allow providing an optional reason when using erlfmt-ignore #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jcpetruzza
force-pushed
the
ignore_with_reason
branch
from
bc96f3e to
9a9b8fc
Compare
Right now only trailing spaces and `%` are allowed in an `erlfmt-ignore`. We make it so that anything after the `erlfmt-ignore` is discarded, effectively allowing for the user to document why formatting is disabled
jcpetruzza
force-pushed
the
ignore_with_reason
branch
from
9a9b8fc to
5dba211
Compare
|
Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now only trailing spaces and
%are allowed in anerlfmt-ignore. We make it so that anything after theerlfmt-ignoreis discarded, effectively allowing for the user to document why formatting is disabled